processor: add WaitForReadyContext method#393
Merged
frairon merged 1 commit intolovoo:masterfrom Sep 20, 2022
Merged
Conversation
Currently the only option to test for processor readines is WaitForReady method. This method is blocking until processor is ready. When processor is dealing with long initialization, this call becomes unresponsive for virtually indefinite time. This behaviour is deal breaker for monitoring calls that just want to check on the status of the processor and return in reasonable amount of time i.e. Kubernetes healthcheck. This change adds context aware method WaitForReadyContext that has all the same checks with addition to context cancelation check. This allows it to return when context is canceled with the context reported error. If the error is not nil it indicates that processor is not ready.
frairon
approved these changes
Sep 15, 2022
Contributor
frairon
left a comment
frairon
left a comment
There was a problem hiding this comment.
looks good, thanks @tymeshifter for that!
Any more comments from @jomaresch or @kavinsk1 maybe? 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only option to test for processor readines is
WaitForReadymethod.This method is blocking until processor is ready.
When processor is dealing with long initialization, this call becomes unresponsive for virtually indefinite time. This behaviour is deal breaker for monitoring calls that just want to check on the status of the processor and return in reasonable amount of time i.e. Kubernetes healthcheck.
This change adds context aware method
WaitForReadyContextthat has all the same checks with addition to context cancelation check. This allows it to return when context is canceled with the context reported error. If the error is not nil it indicates that processor is not ready.