RedisIterator skips first key when it.Next() is called

[chrisfjones]

The Processor.VisitValues function expects it.Next() to be called before accessing any keys. The redisIterator doesn't behave this way and will instead skip over the first key.

[frairon]

Oh damn, that's embarassing. That should've been covered by a test. Thanks for the hint, will take care of that as soon as possible. Unless you want to give it a shot 🙄

[chrisfjones]

No worries! I'm working on a PR now, just adding tests 👍

[frairon]

Awesome, thanks a lot!

[chrisfjones]

Upon further inspection, it appears the contract for storage.Iterator is that it.Next() must be called first before accessing. This is how all the other iterators appear to work, so I've just updated redisIterator to behave that way in this PR #392 👍

[frairon]

Now that you mention it, there was a similar discussion in PR 320 when fixing differences between different storages using Seek. So again, good catch and thanks for the fix :)

I guess we should improve the iterator here and there:

• better documentation + examples
• define behavior when calling Value or Key without having called Next first
• make sure all supported storages are maintained and tested