Separate Request and Response bodies #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds methods and hacks for backwards compatibility.
Adds note in `UPGRADING.md` about custom adapters.
olleolleolle
approved these changes
Feb 20, 2019
Member
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
The documentation addition teaches middleware maintainers what modifications are needed, and if they're affected.
I like this change, and I find it in continuation of the #848 PoC PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates request and response bodies in
Faraday::Env.Adds methods and hacks for backwards compatibility.
Fixes #517