Add test coverage for POST with Retry middleware #389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fails right now on 1.8.7 because |
Contributor
Author
|
Updated to use |
Contributor
Author
|
Can we merge this? :) |
|
I had a quick look to help triage this, and it seems that rebasing this should not be a problem. I just wonder about changing |
Contributor
|
Yeah, let's avoid the renames to keep the diff minimal. |
Nitrodist
force-pushed
the
add-test-coverage-for-post-with-retry-middleware
branch
from
f101933 to
66a8e2f
Compare
There was a fix put in bc82276 (lostisland#296) that preserved the body of a POST request that was being retried in the Retry middleware. Unfortunately, there was no test added that ensures that this functionality continues to work. This commit adds the test to ensure that it continues to work in the future.
Nitrodist
force-pushed
the
add-test-coverage-for-post-with-retry-middleware
branch
from
66a8e2f to
45f5460
Compare
Contributor
Author
|
1 failure now for a failing test in master, it seems. Can we merge now? :) cc @mislav @kennethkalmer |
Contributor
|
Thanks! I've cleaned this up further. |
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a fix put in bc82276 (#296) that preserved the body of a
POST request that was being retried in the Retry middleware.
Unfortunately, there was no test added that ensures that this
functionality continues to work.
This commit adds the test to ensure that it continues to work in the
future.