Skip to content

chore: use NPM workspaces #9562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frbuceta merged 4 commits into from
Jun 3, 2023
Merged

chore: use NPM workspaces #9562

frbuceta merged 4 commits into from
Jun 3, 2023

Conversation

@frbuceta
Copy link
Contributor

@frbuceta frbuceta commented May 23, 2023

No description provided.

@frbuceta frbuceta self-assigned this May 23, 2023
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch 4 times, most recently from b34befd to 80d2bc7 Compare May 24, 2023 00:09
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch 2 times, most recently from 4e59738 to f9c676b Compare May 31, 2023 09:15
@frbuceta
Copy link
Contributor Author

frbuceta commented May 31, 2023 •
edited
Loading

@shubhamp-sf Do you know what might be going on here?

Error: Please install sqlite3 package manually

DriverPackageNotInstalledError: SQLite package has not been found installed. Try to install it: npm install sqlite3 --save

@frbuceta frbuceta mentioned this pull request May 31, 2023
Closed
18 tasks
@shubhamp-sf
Copy link
Contributor

shubhamp-sf commented May 31, 2023 •
edited
Loading

@frbuceta I see the code changes removed package-lock json and lerna bootstrap step. I tried it locally but it didn't install packages for me. So sequelize and typeorm are looking for that package and not finding it.

shubhamp-sf
shubhamp-sf reviewed May 31, 2023
View reviewed changes
@shubhamp-sf
Copy link
Contributor

shubhamp-sf commented May 31, 2023

Btw why are we moving onto NPM workspaces here? Is there any discussion thread I can go through?

@frbuceta
Copy link
Contributor Author

frbuceta commented May 31, 2023

Btw why are we moving onto NPM workspaces here? Is there any discussion thread I can go through?

There is no discussion but I am starting to prepare for migration because of this note on Lerna.

image

@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch from f0e9fef to f9c676b Compare May 31, 2023 10:00
@frbuceta
Copy link
Contributor Author

frbuceta commented May 31, 2023

Also, the project installs the dependencies super fast and that makes the tests in github run much faster.

@shubhamp-sf
Copy link
Contributor

shubhamp-sf commented May 31, 2023

Oh okay, then IMO the only culprit can be require() calls in both typeorm and sequelize for the reason that they require it conditionally It is unable to check them in correct node_modules.

@frbuceta
Copy link
Contributor Author

frbuceta commented May 31, 2023

Oh okay, then IMO the only culprit can be require() calls in both typeorm and sequelize for the reason that they require it conditionally It is unable to check them in correct node_modules.

Yes, that's right. The strange thing is that it only fails in GitHub Actions.

@frbuceta
chore: use NPM Workspaces
4046d0c 
Signed-off-by: Francisco Buceta <[email protected]>
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch from 50dea93 to 8a4aea6 Compare June 1, 2023 20:11
@frbuceta
chore: regenerate lock file
8e1bb34 
Signed-off-by: Francisco Buceta <[email protected]>
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch 9 times, most recently from 7856d55 to 3c7f36e Compare June 1, 2023 22:39
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch 4 times, most recently from e0e5326 to 7989004 Compare June 2, 2023 07:49
@loopbackio loopbackio deleted a comment from coveralls Jun 2, 2023
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch from 7989004 to dc03796 Compare June 2, 2023 10:01
@frbuceta
Copy link
Contributor Author

frbuceta commented Jun 2, 2023 •
edited
Loading

@raymondfeng Can you help me understand what's going on with webpack, with the web compilation?

image

This was referenced Jun 2, 2023
Closed
Open
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch 3 times, most recently from c557915 to 952f360 Compare June 2, 2023 11:15
@frbuceta frbuceta force-pushed the frbuceta/use-workspaces branch from 952f360 to d05b64a Compare June 2, 2023 11:50
@frbuceta frbuceta marked this pull request as ready for review June 2, 2023 23:39
@frbuceta frbuceta merged commit f63f42a into master Jun 3, 2023
@frbuceta frbuceta deleted the frbuceta/use-workspaces branch June 3, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

@achrinza achrinza Awaiting requested review from achrinza achrinza is a code owner

@samarpanB samarpanB Awaiting requested review from samarpanB samarpanB is a code owner

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@nflaig nflaig Awaiting requested review from nflaig nflaig is a code owner

@nabdelgadir nabdelgadir Awaiting requested review from nabdelgadir nabdelgadir is a code owner

@marioestradarosa marioestradarosa Awaiting requested review from marioestradarosa marioestradarosa is a code owner

@mschnee mschnee Awaiting requested review from mschnee mschnee is a code owner

1 more reviewer

@shubhamp-sf shubhamp-sf shubhamp-sf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@frbuceta frbuceta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frbuceta @shubhamp-sf