Skip to content

ci: add Node.js 10 to AppVeyor config (Windows) #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bajtos wants to merge 1 commit into from
Closed

ci: add Node.js 10 to AppVeyor config (Windows) #1431

bajtos wants to merge 1 commit into from

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Jun 14, 2018 •
edited
Loading

This finishes the revert of commit a36e257 (see 5e605c0 from #1350) and configures AppVeyor CI to use the latest Node.js 10.x version, since the problem we were experiencing in 10.1.0 has been fixed in 10.2.0.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@bajtos bajtos self-assigned this Jun 14, 2018
@bajtos bajtos requested a review from raymondfeng as a code owner June 14, 2018 08:26
@bajtos bajtos mentioned this pull request Jun 14, 2018
Merged
7 tasks
@bajtos bajtos changed the title revert: pin Node.js 10.x version to 10.0.0 revert: pin Node.js 10.x version to 10.0.0 (AppVeyor) Jun 14, 2018
@bajtos bajtos mentioned this pull request Jun 14, 2018
Closed
7 tasks
@b-admike
Copy link
Contributor

b-admike commented Jun 14, 2018

@bajtos can you push again to re-trigger appveyor builds?

@bajtos
Copy link
Member Author

bajtos commented Jun 15, 2018

Triggered a new build, looks like it still hangs.

virkt25
virkt25 approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@virkt25 virkt25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once AppVeyor goes green

@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from a217558 to c10dac4 Compare June 28, 2018 12:04
@virkt25
Copy link
Contributor

virkt25 commented Jul 12, 2018

@bajtos can you rebase to trigger the CI again on this PR? AppVeyor now has 10.6.0 available ... so hopefully this fixes our problem? (https://www.appveyor.com/docs/build-environment/#pre-installed-software)

@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from c10dac4 to 5abe218 Compare July 13, 2018 15:29
@bajtos
Copy link
Member Author

bajtos commented Jul 13, 2018

@virkt25

can you rebase to trigger the CI again on this PR? AppVeyor now has 10.6.0 available ... so hopefully this fixes our problem? (https://www.appveyor.com/docs/build-environment/#pre-installed-software)

Done. Feel free to merge this pull request if all builds become green.

@bajtos
Copy link
Member Author

bajtos commented Jul 16, 2018

Unfortunately, the build is still failing :(

@virkt25
Copy link
Contributor

virkt25 commented Jul 16, 2018

Weird ... it failed without any messages, timeouts from Mocha or anything.

@bajtos
Copy link
Member Author

bajtos commented Jul 16, 2018

Weird ... it failed without any messages, timeouts from Mocha or anything.

This is the same problem we have been experiencing from the start, see #1350 (comment):

looks like there is some other bug on Windows, the test run freezes inside our test suite.

I have described details in nodejs/node#21210. In short, the callback installed via setImmediate is never invoked, the Node.js process hangs forever and after one hour, AppVeyor gives up waiting and kills the build as timed out.

@virkt25
Copy link
Contributor

virkt25 commented Jul 16, 2018

Ah right. Thanks for the explanation again. I thought it was fixed in the latest release ... :( Thanks for trying again.

@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from 5abe218 to c7e5f64 Compare August 31, 2018 11:46
@bajtos
Copy link
Member Author

bajtos commented Aug 31, 2018

Rebased on top of the latest master, still no luck with Node.js 10.9.0 :(

@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from c7e5f64 to 653ae96 Compare October 18, 2018 10:52
@bajtos
Copy link
Member Author

bajtos commented Oct 18, 2018

Still hanging :(

@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from 653ae96 to a825ff4 Compare November 5, 2018 08:25
@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from a825ff4 to 993a57e Compare January 25, 2019 08:21
@bajtos bajtos mentioned this pull request Feb 4, 2019
Merged
7 tasks
@bajtos bajtos added the Internal Tooling Issues related to our tooling and monorepo infrastructore label Feb 12, 2019
@bajtos bajtos mentioned this pull request Mar 8, 2019
Merged
@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from 993a57e to e030881 Compare May 7, 2019 15:39
@bajtos bajtos changed the title revert: pin Node.js 10.x version to 10.0.0 (AppVeyor) ci: add Node.js 10 to AppVeyor config (Windows) May 7, 2019
@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch 2 times, most recently from 59f1716 to f37c75a Compare May 7, 2019 15:42
@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from f37c75a to cded4e9 Compare September 9, 2019 09:08
@bajtos
ci: add Node.js 10 & 12 to AppVeyor config (Windows)
8615d3a 
This finishes the revert of commit a36e257 (see 5e605c0) and
configures AppVeyor CI to use the latest Node.js 10.x and 12.x versions.
@bajtos bajtos force-pushed the ci/reenable-latest-10x-appveyor branch from cded4e9 to 8615d3a Compare September 9, 2019 09:12
@bajtos
Copy link
Member Author

bajtos commented Sep 9, 2019

Still no luck, both Node.js 10 and 12 end up in a frozen state when running our tests.

I feel there is no point in keeping this pull request open. Instead of troubleshooting AppVeyor, I prefer to investigate migration to Azure Pipelines - see #3161

@bajtos bajtos closed this Sep 9, 2019
@bajtos bajtos deleted the ci/reenable-latest-10x-appveyor branch September 9, 2019 11:02
@bajtos bajtos added the os:Windows Issues specific to Windows label Oct 15, 2019
@bajtos bajtos mentioned this pull request Jan 14, 2020
Closed
@bajtos
Copy link
Member Author

bajtos commented Feb 17, 2020

As of 4281d9d, we are using Node.js 10 LTS on AppVeyor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

2 more reviewers

@virkt25 virkt25 virkt25 approved these changes

@b-admike b-admike b-admike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bajtos bajtos

Labels

Internal Tooling Issues related to our tooling and monorepo infrastructore os:Windows Issues specific to Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bajtos @b-admike @virkt25