Update mongodb to ^3.6.4 #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wolrajhti <[email protected]>
wolrajhti
requested review from
agnes512,
dhmlau,
emonddr,
hacksparrow and
jannyHou
as code owners
agnes512
approved these changes
Feb 16, 2021
Contributor
agnes512
left a comment
agnes512
left a comment
There was a problem hiding this comment.
Thank you for the PR ❤️ I saw the issue that day, but I was not able to stop it outputting warnings :( But still, thanks for adding support for new format!
Contributor
Author
|
Hi I just submit a PR to node-mongodb-native driver to fix the merging of writeConcern mongodb/node-mongodb-native#2744 which stop warning outputs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wolrajhti [email protected]
Since 3.6.4 mongodb driver
console.warnover and over a depreciation message related to the new format for WriteConcern options. This PR add support for new format, while keeping backward compatibility.(There is an opened issue for the mongodb driver, https://jira.mongodb.org/browse/NODE-3114, so this PR alone will not disable all ##console.warn).
Related issue
#616
Checklist
npm testpasses on your machine