Add new fields to status table in STATE_DB#2
Open
longhuan-cisco wants to merge 12 commits intomasterfrom
Open
Conversation
* Push new fields to DOM_SENSOR table in STATE_DB * Remove empty line Signed-off-by: Longyin Huang longhuan@cisco.com
AnoopKamath
reviewed
Oct 13, 2022
| fvs = swsscommon.FieldValuePairs([('status', status), ('error', error_descriptions)]) | ||
| status_tbl.set(logical_port_name, fvs) | ||
|
|
||
| # Update port SFP status table for HW fields |
There was a problem hiding this comment.
You have created 2 different functions to update *status_table_hw and *status_table_sw but does it update same status table? what are variables here?
Owner
Author
There was a problem hiding this comment.
one is for updating SW fields which are non eeprom-fetched ('status' 'error' ); one is for updating HW fields which are eeprom-fetched. I updated in the PR description about which are SW fields, which are HW fields.
* Add pm tbl to STATE_DB * Use unique info in post_port_pm_info_to_db log
longhuan-cisco
force-pushed
the
add_to_status_tbl
branch
from
9b9fe4d to
fa6ce8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the status table's DB schema, refer to this HLD from PR sonic-net/SONiC#1076
following SW fields(non-eeprom-fetched) are already present in today's status table:
following HW fields (eeprom-fetched) are added:
UT output:
status_tbl_ut_output.txt