Release the i18next-shopify framework#970
Merged
Merged
Conversation
This commit adds the `supportAutoExtraction` array of supported formats and the `detectHardStrings` method from `GeneralFramework` to enable hard-coded string extraction for react-i18next framework, without needing the "general" framework to be enabled/loaded in the `.vscode/settings.json` file.
This commit adds the i18next-shopify framework to the list of supported frameworks. It is an extension of the React i18next framework, with some configuration changes. Also add i18next-shopify example app, including a pluralization example.
Derived keys (e.g., such as plurals) were being miscategorised as missing in the usage report. This commit checks if keys derived from those found in the missing list (keys that are in use but considered "not defined") are included in the list of idle keys (keys defined but not considered in use), indicating that they are indeed defined and in use. Fixes lokalise#953
…ext_framework Add extraction support to react-i18next framework
Add i18next-shopify framework
…ng_value Display first available pluralization string if parent key of nested pluralization keys
…sted_pluralization_keys Add support for "Go to Definition" for pluralization strings
Fixes usage report for non-missing derived keys
Derived keys (e.g., such as plurals) are being miscategorised as not found in the Current File Panel report. This commit checks if any existing key paths match derived keys paths, and if so, includes them in the list of in use key paths and removed from the "not found" list. Fixes lokalise#959
…ort_derived_keys Fixes Current File Panel report of not found keys
trishrempel
changed the title
i18next-shopify frameworki18next-shopify framework
Chore: fix spelling (strings, variables) within code base
terales
approved these changes
Jul 11, 2023
This was referenced Jul 11, 2023
huacnlee
pushed a commit
to huacnlee/i18n-ally
that referenced
this pull request
Aug 28, 2023
* Return first available counting value if nested * Add extraction support to react-i18next framework This commit adds the `supportAutoExtraction` array of supported formats and the `detectHardStrings` method from `GeneralFramework` to enable hard-coded string extraction for react-i18next framework, without needing the "general" framework to be enabled/loaded in the `.vscode/settings.json` file. * Add i18next-shopify framework This commit adds the i18next-shopify framework to the list of supported frameworks. It is an extension of the React i18next framework, with some configuration changes. Also add i18next-shopify example app, including a pluralization example. * Add support for Go to Definition of a translation key * Fixes usage report for non-missing derived keys Derived keys (e.g., such as plurals) were being miscategorised as missing in the usage report. This commit checks if keys derived from those found in the missing list (keys that are in use but considered "not defined") are included in the list of idle keys (keys defined but not considered in use), indicating that they are indeed defined and in use. Fixes lokalise#953 * Fixes Current File Panel report of not found keys Derived keys (e.g., such as plurals) are being miscategorised as not found in the Current File Panel report. This commit checks if any existing key paths match derived keys paths, and if so, includes them in the list of in use key paths and removed from the "not found" list. Fixes lokalise#959 * Chore: fix spellings in code base --------- Co-authored-by: Kevin O'Sullivan <mkevin.osullivan@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a release branch for the following PRs:
Tophatting
Run the extension in debug mode and open the i18n-ally folder
examples/by-frameworks/i18next-shopify.Confirm that:
i18next-shopifyframework enabled: