Update .travis.yml to ajust to new release cadence#148
Merged
Conversation
Contributor
|
Assigned myself to look in to the failures in the |
From ruby/uri#107: ``` This pull-request switched URI::DEFAULT_PARSER to URI::RFC3986_Parser. And I added switch-back feature for URI::RFC2396_Parser. URI.parser = URI::RFC2396_PARSER ``` If the `URI::RFC2396_PARSER` constant is not defined (using an older URI lib) then fall back to using the default.
donoghuc
force-pushed
the
jsvd-patch-2
branch
from
eae48f4 to
3376254
Compare
donoghuc
approved these changes
Nov 20, 2024
Contributor
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
For the 7.x tests it looks like the environment had an old uri lib without the new constant defined. Tests were failing with:
logstash-1 | Failure/Error: raise LogStash::ConfigurationError, "Invalid URL #{url}" unless URI::RFC2396_PARSER.regexp[:ABS_URI].match(url)
logstash-1 |
logstash-1 | NameError:
logstash-1 | uninitialized constant URI::RFC2396_PARSER
logstash-1 | Did you mean? URI::RFC2396_Parser
logstash-1 | URI::RFC3986_Parser
logstash-1 | URI::RFC3986_PARSER
I pushed to the commit updating the constant to handle both cases by determining if the new constant is defined. If not defined, it uses the old value.
Contributor
|
@jsvd I will wait for you to get a chance to double check my addition to your commit before merging. |
Member
Author
|
@donoghuc thanks for that addition, merged 🚢 |
Member
|
@jsvd Should this be released, given the URI gem change? Is this something that could bite actual users of the plugin, or just relevant in tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.