fix: close pending iterators before closing LevelDB store#83
Merged
Conversation
…tors. It: 1. disposes of iterators automatically when the iterator is finished; 2. does a bit of test refactoring to reflect that.
closed before we try to close the database.
emizzle
approved these changes
Feb 6, 2026
Comment on lines
+112
to
+113
| iter.disposed = true | ||
| self.openIterators.excl(iter) |
Contributor
There was a problem hiding this comment.
Possible optimisation: check iter.disposed first?
Contributor
Author
There was a problem hiding this comment.
Those are so fast and the operation so infrequent that's probably not even worth the trouble... (plus dbIter.dispose is idemptotent)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tracking of open iterators to leveldbds so that when one attempts to close it, iterators are disposed of first. It also adds automatic disposal if iterators are completely consumed.
fixes #82