Skip to content

Conversation

@papertowel123
Copy link

@papertowel123 papertowel123 commented Jul 25, 2024

reason for change: added the ability to set certain parameters for each sub-polygons (for limit, slowdown and approach type of velocity polygons)

so now, for each sub-polygon we can specify the slowdown_ration parameter:

    VelocityPolygonStop:
      type: "velocity_polygon"
      action_type: "slowdown"
      min_points: 6
      visualize: True
      enabled: True
      polygon_pub_topic: "velocity_polygon_stop"
      velocity_polygons: ["rotation", "translation_forward", "translation_backward", "stopped"]
      holonomic: false
      rotation:
        points: "[[0.3, 0.3], [0.3, -0.3], [-0.3, -0.3], [-0.3, 0.3]]"
        linear_min: 0.0
        linear_max: 0.05
        theta_min: -1.0
        theta_max: 1.0
        slowdown_ration: 0.4
      translation_forward:
        points: "[[0.35, 0.3], [0.35, -0.3], [-0.2, -0.3], [-0.2, 0.3]]"
        linear_min: 0.0
        linear_max: 1.0
        theta_min: -1.0
        theta_max: 1.0
        slowdown_ration: 0.2
      translation_backward:
        points: "[[0.2, 0.3], [0.2, -0.3], [-0.35, -0.3], [-0.35, 0.3]]"
        linear_min: -1.0
        linear_max: 0.0
        theta_min: -1.0
        theta_max: 1.0
        slowdown_ration: 0.1

Signed-off-by: maksymdidukh <[email protected]>
@papertowel123 papertowel123 requested a review from jplapp as a code owner July 25, 2024 11:04
@papertowel123 papertowel123 force-pushed the improve_velocity_polygon_params branch from 55a04a0 to c2c182f Compare July 29, 2024 09:10
.
Signed-off-by: maksymdidukh <[email protected]>
Signed-off-by: maksymdidukh <[email protected]>
Signed-off-by: maksymdidukh <[email protected]>
Signed-off-by: maksymdidukh <[email protected]>
Signed-off-by: maksymdidukh <[email protected]>
@papertowel123 papertowel123 force-pushed the improve_velocity_polygon_params branch from 969df62 to eed24f9 Compare July 30, 2024 12:41
Copy link

@jplapp jplapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach is now incompatible to the upstream approach,so we wont be able to push this. We should make it so that these velocities are optional: If they are not defined for the polygon, the "main" ones should be used instead. But let's do that as a follow-up step

@papertowel123 papertowel123 self-assigned this Jul 31, 2024
@papertowel123 papertowel123 merged commit e137193 into transient_local_publish Jul 31, 2024
papertowel123 added a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants