Skip to content

Allow python3.12#124

Merged
garyservin merged 2 commits into
masterfrom
allow-python3.12
Jun 1, 2026
Merged

Allow python3.12#124
garyservin merged 2 commits into
masterfrom
allow-python3.12

Conversation

@garyservin

Copy link
Copy Markdown
Contributor

Without these fixes, we get

Traceback (most recent call last):
  File "/usr/local/bin/catkin", line 5, in <module>
    from catkin_tools.commands.catkin import main
  File "/opt/locusrobotics/virtualenv/catkin-tools/lib/python3.12/site-packages/catkin_tools/commands/catkin.py", line 21, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

when trying to run on noble. These changes seem to work fine on jammy as well

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the virtualenv bootstrap and pinned Python dependencies to support Python 3.12 environments (e.g., Ubuntu Noble) where pkg_resources is no longer available by default.

Changes:

  • Update venv.py preinstall bootstrap packages (pip/pip-tools) and add setuptools so pkg_resources is present.
  • Refresh pinned transitive dependencies in requirements.txt to newer versions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
catkin_virtualenv/src/catkin_virtualenv/venv.py Updates bootstrap packages installed into newly created virtualenvs to work on Python 3.12.
catkin_virtualenv/requirements.txt Updates pinned dependency set intended to be installed/redistributed with the package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread catkin_virtualenv/src/catkin_virtualenv/venv.py Outdated
Comment thread catkin_virtualenv/requirements.txt Outdated
@garyservin garyservin force-pushed the allow-python3.12 branch 2 times, most recently from e005dd0 to 2e4d265 Compare May 12, 2026 15:19
@garyservin garyservin requested review from Copilot and jprestwo June 1, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread catkin_virtualenv/src/catkin_virtualenv/venv.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread catkin_virtualenv/src/catkin_virtualenv/venv.py
Comment thread catkin_virtualenv/src/catkin_virtualenv/venv.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@@ -202,6 +214,19 @@ def _find_pip_compile(self):
raise RuntimeError("pip-compile not found found in Venv or global PATH") from exc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring this, not related to the PR

@garyservin garyservin marked this pull request as ready for review June 1, 2026 14:59
@garyservin garyservin merged commit 0ff410f into master Jun 1, 2026
5 checks passed
@garyservin garyservin deleted the allow-python3.12 branch June 1, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants