Allow python3.12#124
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the virtualenv bootstrap and pinned Python dependencies to support Python 3.12 environments (e.g., Ubuntu Noble) where pkg_resources is no longer available by default.
Changes:
- Update
venv.pypreinstall bootstrap packages (pip/pip-tools) and add setuptools sopkg_resourcesis present. - Refresh pinned transitive dependencies in
requirements.txtto newer versions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
catkin_virtualenv/src/catkin_virtualenv/venv.py |
Updates bootstrap packages installed into newly created virtualenvs to work on Python 3.12. |
catkin_virtualenv/requirements.txt |
Updates pinned dependency set intended to be installed/redistributed with the package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f91fdb4 to
3c5e565
Compare
e005dd0 to
2e4d265
Compare
2e4d265 to
be520b0
Compare
be520b0 to
c2686b4
Compare
jprestwo
approved these changes
Jun 1, 2026
| @@ -202,6 +214,19 @@ def _find_pip_compile(self): | |||
| raise RuntimeError("pip-compile not found found in Venv or global PATH") from exc | |||
Contributor
Author
There was a problem hiding this comment.
Ignoring this, not related to the PR
biancabnd
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these fixes, we get
when trying to run on noble. These changes seem to work fine on jammy as well