Skip to content

Conversation

@alwayys-afk
Copy link

@alwayys-afk alwayys-afk commented Oct 10, 2025

Some of the tests had this pattern:

async fn request_internal<F, Fut>(callback: F, boot: &BootResult, test_server_config: RequestConfig)
where
    F: FnOnce(TestServer, AppContext) -> Fut,
    Fut: std::future::Future<Output = ()>,

switched to this:

async fn request_internal(
    callback: impl AsyncFnOnce(TestServer, AppContext),
    boot: &BootResult,
    test_server_config: RequestConfig)

@alwayys-afk alwayys-afk force-pushed the updating-async-fn-constraint branch from 8c908d5 to 3833e0d Compare October 10, 2025 19:02
Copy link

@dsgallups dsgallups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though the PR description doesn't quite match what this does.
Before:

request::<App, _, _>(|test_server, etc)| async { ... });

This PR:

request::<App>(|test_server, etc)| async { ... });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants