Skip to content

Conversation

@margsliu
Copy link
Contributor

No description provided.

@CrypticSwarm CrypticSwarm merged commit 5286626 into master Aug 28, 2019
@CrypticSwarm CrypticSwarm deleted the live_demo_initial_link branch August 28, 2019 00:25
pskupinski pushed a commit to pskupinski/coral.js that referenced this pull request Nov 5, 2025
This commit addresses issues lockerdome#1 and lockerdome#2 from the code review:
- Eliminated all 13 security vulnerabilities (now 0 vulnerabilities)
- Updated outdated dependencies to modern, secure versions

Security Fixes:
- Fixed elliptic cryptographic vulnerabilities (multiple CVEs)
- Fixed cipher-base hash rewind attacks
- Fixed pbkdf2 predictable memory issues
- Fixed sha.js missing type checks
- Fixed browserify-sign signature forgery
- Fixed minimist prototype pollution (by migrating to yargs)
- Fixed all ReDoS vulnerabilities in minimatch, acorn, etc.

Dependency Updates:
- browserify: 16.2.3 → 17.0.0 (security fixes)
- esprima: 2.7.3 → 4.0.1 (major update, modern parser)
- estraverse: 1.5.0 → 5.3.0 (major update)
- html-entities: x.x.x → 2.5.2 (FIXED unpinned version!)
- uglify-js: 2.4.24 → 3.17.4 (security fixes)
- mkdirp: 0.3.5 → 1.0.4 (modern API)
- optimist → yargs 17.7.2 (migrated from deprecated package)
- inherits: 2.0.1 → 2.0.4
- tosource: 0.1.1 → 1.0.0
- es6-promise: 4.2.5 → 4.2.8

DevDependencies:
- chai: 1.6.0 → 4.4.1 (major update)
- mocha: added 10.8.2 (was missing!)

Other Changes:
- Migrated cli/cli.js from optimist to yargs
- Replaced npm-shrinkwrap.json with package-lock.json
- All 22 existing tests pass with updated dependencies

npm audit results: 13 vulnerabilities → 0 vulnerabilities ✓
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants