Update gdal-warp-bindings v1.1.1 #3303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
approved these changes
Nov 14, 2020
Member
pomadchin
left a comment
pomadchin
left a comment
There was a problem hiding this comment.
Thanks, works wonderful! Tests passed for me with the local brew GDAL 3.2.0 installed and symlinked to match the GDAL 3.1.x dylib version: ln -s /usr/local/lib/libgdal.28.dylib /usr/local/lib/libgdal.27.dylib
I left a minor comment about the CHANGELOG. And we need to file a CQ before merging it!
Contributor
Author
|
CQ Approved! |
Contributor
Author
|
Going to await testing by @moradology before merge. |
Member
Contributor
Author
|
👍 |
Member
|
How about merging it in and rising a new issue if it would happen to be the case? We'd anyway have to publish a GDAL 3.2.x release soonish => there would definitely be a chance to return back to it. I'd like to get this PR into the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates gdal-warp-bindings to the newly released 1.1.1 to address MacOS dylib issues.
Checklist