Buffer for resample by only half a pixel #3302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moradology
force-pushed
the
fix/npz/layout-tile-resample-oob
branch
from
3200a91 to
72392b5
Compare
pomadchin
requested changes
Nov 11, 2020
Member
pomadchin
left a comment
pomadchin
left a comment
There was a problem hiding this comment.
This one looks good to me, nice PR; thx @moradology! I still have a feeling that this still may hit us one day, but that is perfect for now.
I left a minor question about the test (checkExtent signature looks a bit suspicious).
And the ECA is still pending (requires a renewal), if you have troubles with signing it, feel free to reach me!
layer/src/test/scala/geotrellis/layer/LayoutTileSourceSpec.scala
Outdated
Show resolved
Hide resolved
layer/src/test/scala/geotrellis/layer/LayoutTileSourceSpec.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: moradology <[email protected]>
moradology
force-pushed
the
fix/npz/layout-tile-resample-oob
branch
from
64a2fba to
47daab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
LayoutTileSourceresamples were sometimes going out of bounds. In those cases,Resampleshort circuits toNODATAChecklist
docsguides update, if necessaryCloses #3299