Fix NoData handling in the ColorMethods.color function for the RGB and RGBA Multiband Rasters #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
pomadchin
force-pushed
the
fix/rgba-color
branch
2 times, most recently
from
00c8539 to
8a56a6a
Compare
pomadchin
commented
Aug 1, 2020
Comment on lines
+51
to
+57
| var transparent = true | ||
| val r = if (isData(rBand)) { transparent = false; rBand } else 0 | ||
| val g = if (isData(gBand)) { transparent = false; gBand } else 0 | ||
| val b = if (isData(bBand)) { transparent = false; bBand } else 0 | ||
|
|
||
| if(r + g + b == 0) 0 | ||
| else { | ||
| ((r & 0xFF) << 24) | ((g & 0xFF) << 16) | ((b & 0xFF) << 8) | 0xFF | ||
| } | ||
| if(transparent) 0 | ||
| else ((r & 0xFF) << 24) | ((g & 0xFF) << 16) | ((b & 0xFF) << 8) | 0xFF |
Member
Author
There was a problem hiding this comment.
I wanted to make this "transparency" detection cheaper, since this function is applied to all pixels of the raster.
pomadchin
force-pushed
the
fix/rgba-color
branch
from
8a56a6a to
0a79d7b
Compare
This was referenced Aug 1, 2020
Closed
pomadchin
force-pushed
the
fix/rgba-color
branch
from
5284dba to
e11401e
Compare
pomadchin
force-pushed
the
fix/rgba-color
branch
from
e11401e to
0f57246
Compare
CloudNiner
approved these changes
Aug 4, 2020
Contributor
CloudNiner
left a comment
CloudNiner
left a comment
There was a problem hiding this comment.
LGTM nice test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the NoData interpretation by the
ColorMethods.colorfunction.With the current fix for RGBA Rasters the zero would be set only in case the alpha channel is set to 0 as well.
In the RGB case, the alpha channel would be set to zero only when all the 3 bands are filled with nodata values.
Checklist
Fix #3203