-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
💄 style: adjust ControlsForm component to adapt to mobile phone display #9013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bbbugg is attempting to deploy a commit to the LobeHub Community Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's GuideThe PR refactors the ControlsForm component to improve mobile responsiveness by converting fixed-width inline-block description spans into block-level elements with maxWidth and normal text wrapping, and removes the hardcoded width from the URL context control. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
👍 @bbbugg Thank you for raising your pull request and contributing to our Community |
TestGru AssignmentSummary
Tip You can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Extract the repeated inline style for the description spans into a shared styled component or CSS class to reduce duplication and improve maintainability.
- Consider centralizing the maxWidth values as theme tokens or constants to ensure consistent sizing across the form.
- Verify that the new wrapping behavior works across all mobile breakpoints and doesn’t introduce horizontal overflow.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Extract the repeated inline style for the description spans into a shared styled component or CSS class to reduce duplication and improve maintainability.
- Consider centralizing the maxWidth values as theme tokens or constants to ensure consistent sizing across the form.
- Verify that the new wrapping behavior works across all mobile breakpoints and doesn’t introduce horizontal overflow.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9013 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 810 810
Lines 48848 48848
Branches 6587 6586 -1
=======================================
Hits 37696 37696
Misses 11146 11146
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
eff59dd to
b003c1f
Compare
|
感觉 switch 那个组件应该换到第二行? |
I feel that switch component should be switched to the second line? |
换到第二行中间吗,感觉有点丑啊哈哈 |
Do you change to the middle of the second line? It feels a bit ugly haha |
|
第二行左边,你看下移动端设置里面,这种开关都是放第二行左边的 |
On the left side of the second line, you can look at the mobile terminal settings. These switches are placed on the left side of the second line. |
…s on narrow screens
00cbc3b to
bbfc95f
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
❤️ Great PR @bbbugg ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.120.4](v1.120.3...v1.120.4) <sup>Released on **2025-09-01**</sup> #### 💄 Styles - **misc**: Adjust ControlsForm component to adapt to mobile phone display. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Styles * **misc**: Adjust ControlsForm component to adapt to mobile phone display, closes [#9013](#9013) ([c6038c0](c6038c0)) </details> <div align="right"> [](#readme-top) </div>
|
🎉 This PR is included in version 1.120.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [Version 1.120.0](v1.119.1...v1.120.0) <sup>Released on **2025-09-02**</sup> #### ♻ Code Refactoring - **model-runtime**: Refactor model-runtime dependencies and clean code. - **misc**: Remove base path, remove webrtc sync feature flag. #### ✨ Features - **misc**: Added support for Azure OpenAI Image Generation, rename Gemini 2.5 flash image to Nano Banana. #### 🐛 Bug Fixes - **ai-image**: Save config.imageUrl with fullUrl instead of key. - **misc**: Update enableStreaming name. #### 💄 Styles - **misc**: Add upload hint for non-visual model, adjust ControlsForm component to adapt to mobile phone display, Support new provider Nebius, update i18n, update i18n. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **model-runtime**: Refactor model-runtime dependencies and clean code, closes [lobehub#8997](https://github.com/jaworldwideorg/OneJA-Bot/issues/8997) ([9f7677d](9f7677d)) * **misc**: Remove base path, closes [lobehub#9015](https://github.com/jaworldwideorg/OneJA-Bot/issues/9015) ([2a5f8d7](2a5f8d7)) * **misc**: Remove webrtc sync feature flag, closes [lobehub#9002](https://github.com/jaworldwideorg/OneJA-Bot/issues/9002) ([0924d98](0924d98)) #### What's improved * **misc**: Added support for Azure OpenAI Image Generation, closes [lobehub#8898](https://github.com/jaworldwideorg/OneJA-Bot/issues/8898) ([6042340](6042340)) * **misc**: Rename Gemini 2.5 flash image to Nano Banana, closes [lobehub#9004](https://github.com/jaworldwideorg/OneJA-Bot/issues/9004) ([dac5a6f](dac5a6f)) #### What's fixed * **ai-image**: Save config.imageUrl with fullUrl instead of key, closes [lobehub#9016](https://github.com/jaworldwideorg/OneJA-Bot/issues/9016) ([bad009a](bad009a)) * **misc**: Update enableStreaming name, closes [lobehub#8995](https://github.com/jaworldwideorg/OneJA-Bot/issues/8995) ([7c7de40](7c7de40)) #### Styles * **misc**: Add upload hint for non-visual model, closes [lobehub#7969](https://github.com/jaworldwideorg/OneJA-Bot/issues/7969) ([1224f4e](1224f4e)) * **misc**: Adjust ControlsForm component to adapt to mobile phone display, closes [lobehub#9013](https://github.com/jaworldwideorg/OneJA-Bot/issues/9013) ([c6038c0](c6038c0)) * **misc**: Support new provider Nebius, closes [lobehub#8903](https://github.com/jaworldwideorg/OneJA-Bot/issues/8903) ([c15791d](c15791d)) * **misc**: Update i18n, closes [lobehub#9033](https://github.com/jaworldwideorg/OneJA-Bot/issues/9033) ([650e552](650e552)) * **misc**: Update i18n, closes [lobehub#9005](https://github.com/jaworldwideorg/OneJA-Bot/issues/9005) ([63760f9](63760f9)) </details> <div align="right"> [](#readme-top) </div>
…ay (lobehub#9013) * 🐛 fix: adjust ControlsForm component to use responsive widths for descriptions * 🐛 fix: update ControlsForm component for responsive description widths on narrow screens
### [Version 1.120.4](lobehub/lobe-chat@v1.120.3...v1.120.4) <sup>Released on **2025-09-01**</sup> #### 💄 Styles - **misc**: Adjust ControlsForm component to adapt to mobile phone display. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Styles * **misc**: Adjust ControlsForm component to adapt to mobile phone display, closes [lobehub#9013](lobehub#9013) ([c6038c0](lobehub@c6038c0)) </details> <div align="right"> [](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
对话窗口的模型控制组件宽度调整,在宽度减少时自动换行,适配移动端显示
修改前:
修改后:
📝 补充信息 | Additional Information
Summary by Sourcery
Bug Fixes: