💄 style: add sorting functionality for disabled models and model providers with tooltip support #10000
+256
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbbugg is attempting to deploy a commit to the LobeHub Community Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:L
Reviewer's GuideAdds alphabetical and default sorting toggles with tooltip support for disabled models and model providers, updating UI components and localization entries to enhance discoverability. Entity relationship diagram for updated localization entrieserDiagram
MODEL_PROVIDER {
string list_disabled
string list_enabled
object list_disabledActions
}
DISABLED_ACTIONS {
string sortAlphabetical
string sortDefault
string showMore
}
MODEL_PROVIDER ||--o{ DISABLED_ACTIONS : contains
Class diagram for updated DisabledModels and ProviderList componentsclassDiagram
class DisabledModels {
- showMore: boolean
- sortType: SortType
+ toggleSortType()
+ getSortTooltip()
+ sortedDisabledModels: Model[]
}
class ProviderList {
- open: boolean
- sortType: SortType
+ toggleSortType()
+ getSortTooltip()
+ sortedDisabledProviders: Provider[]
}
class SortType {
<<enumeration>>
Alphabetical
Default
}
DisabledModels --> SortType
ProviderList --> SortType
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
👍 @bbbugg Thank you for raising your pull request and contributing to our Community |
TestGru AssignmentSummary
Tip You can |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Extract SortType and the sorting logic into a shared utility or custom hook to avoid duplicating it in DisabledModels and ProviderList.
- Unify the i18n keys for the sort tooltips under a consistent namespace so both models and providers use the same translation paths.
- Since this PR adds new interactive sorting behavior, consider updating the commit/PR type from 'style' to 'feat' to better reflect the feature.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Extract SortType and the sorting logic into a shared utility or custom hook to avoid duplicating it in DisabledModels and ProviderList.
- Unify the i18n keys for the sort tooltips under a consistent namespace so both models and providers use the same translation paths.
- Since this PR adds new interactive sorting behavior, consider updating the commit/PR type from 'style' to 'feat' to better reflect the feature.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #10000 +/- ##
==========================================
+ Coverage 81.90% 81.96% +0.05%
==========================================
Files 879 881 +2
Lines 56224 56754 +530
Branches 7692 7507 -185
==========================================
+ Hits 46051 46517 +466
- Misses 10173 10237 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
I suggest making it similar to this. There might be other sorting modes in the future.
Original Content
建议做成类似这样的,未来说不定还有别的排序模式 |
arvinxx
force-pushed
the
style/model-sort
branch
from
d28b756 to
a006140
Compare
|
The data from localStorage needs to be read in systemStatus. You can check the related implementation in globalStore for reference.
Original ContentlocalStorage 的数据需要放到 systemStatus 这个里读取。可以看下 globalStore 的这块相关实现 |
…ders with tooltip support
…ding/descending options
…/descending functionality
bbbugg
force-pushed
the
style/model-sort
branch
from
a006140 to
69d4b49
Compare
arvinxx
requested changes
Nov 4, 2025
| ) as SortType) || SortType.Default, | ||
| ); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
const sortType = useGlobalStore(systemStatusSelectors.disabledModelProvidersSortType)
不需要再包一层 useState 和 useEffect
bbbugg
force-pushed
the
style/model-sort
branch
from
5246742 to
fc09cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
🔀 Description of Change
给未开启的模型新增按字母排序、按发布时间排序功能。
给未开启的模型服务商新增按字母排序功能。
排序方式保存在浏览器缓存。
🧪 How to Test
📸 Screenshots / Videos
模型服务商列表
模型列表
📝 Additional Information
Summary by Sourcery
Add alphabetical sorting toggle for disabled models and providers with tooltip support.
Enhancements:
Documentation: