Add support for seperate name table (ServerDBAdapter support only)#113
Merged
lmg-anon merged 2 commits intolmg-anon:namestorefrom Oct 28, 2025
Merged
Add support for seperate name table (ServerDBAdapter support only)#113lmg-anon merged 2 commits intolmg-anon:namestorefrom
lmg-anon merged 2 commits intolmg-anon:namestorefrom
Conversation
4 tasks
9 tasks
|
@saood06 i've merged your PR and tried to use your version. However i'm getting this error in the console: and the page doesn't display anything. Would you mind letting me know how to use enable your PR? Thanks. |
Owner
|
Thank you for your contribution! This sounds like a great change, I'm going to finish it and merge to main later. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #102 (comment) with a large amount of entries the initial loadtime can take minutes as even though sessions only returns the name the json_extract is very costly. This change makes startup down time in the realm of seconds now which is much more tolerable.
I also found that the data is highly compressible via: phiresky/sqlite-zstd in my case, tested across two different databases:
Compressed 14752 rows Total size of entries before: 31.04GB, afterwards: 3.40GB, (average: before=2.10MB, after=230.77kB)Compressed 8042 rows Total size of entries before: 8.62GB, afterwards: 581.33MB, (average: before=1.07MB, after=72.29kB)I used the following migration script (after making a backup):
And the following compression script:
The train_dict_samples_ratio should be set according to your datasize (see phiresky/sqlite-zstd#16 and phiresky/sqlite-zstd#11), and compression_level according to your preference (I set 19 and waited patiently).
In the code you say: "TODO: Remove saveQueue" but I think saveQueue can be kept if it is set to 10 minutes (similar to how desktop office suites do autosave). It is how I am using it.