Mark docstrings with backslashes as raw strings #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids Python issuing a SyntaxWarning about an unrecognized escape sequence. The only occurrences were in one test file. Note that some strings had a `u` prefix replaced with `r`. The `u` prefix was needed for Python 2. These strings did not work with a `ur` prefix. Since Python 2 is no longer supported, no other means of keeping support with Python 2 was attempted.
wshanks
force-pushed
the
docstring-escapes
branch
from
6becfd4 to
561281e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 12 12
Lines 1905 1905
=======================================
Hits 1824 1824
Misses 81 81 ☔ View full report in Codecov by Sentry. |
Closed
Member
|
@wshanks I am +1 on just merging this. Any objections? |
Contributor
Author
Not from me 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids Python issuing a SyntaxWarning about an unrecognized escape sequence. The only occurrences were in one test file.
Note that some strings had a
uprefix replaced withr. Theuprefix was needed for Python 2. These strings did not work with a
urprefix. Since Python 2 is no longer supported, no other means of keeping
support with Python 2 was attempted.