Skip to content

[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp #89967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp #89967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3291c6a
[IRCE] Skip icmp ptr in `InductiveRangeCheck::parseRangeCheckICmp`
dtcxzyw Apr 24, 2024
356fd65
[IRCE] Address review comments.
dtcxzyw Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,10 @@ bool InductiveRangeCheck::parseRangeCheckICmp(Loop *L, ICmpInst *ICI,
Value *LHS = ICI->getOperand(0);
Value *RHS = ICI->getOperand(1);

// ICmp with pointers are unsupported.
if (LHS->getType()->isPtrOrPtrVectorTy())
return false;

// Canonicalize to the `Index Pred Invariant` comparison
if (IsLoopInvariant(LHS)) {
std::swap(LHS, RHS);
Expand Down
33 changes: 33 additions & 0 deletions llvm/test/Transforms/IRCE/pr89959.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
; RUN: opt -passes=irce -S < %s 2>&1 | FileCheck %s

; Make sure we don't crash.
define void @pr89959() {
; CHECK-LABEL: define void @pr89959() {
; CHECK-NEXT: top:
; CHECK-NEXT: br label [[L3:%.*]]
; CHECK: L3:
; CHECK-NEXT: [[VALUE_PHI:%.*]] = phi ptr [ null, [[TOP:%.*]] ], [ [[TMP0:%.*]], [[L13:%.*]] ]
; CHECK-NEXT: [[TMP0]] = getelementptr i8, ptr [[VALUE_PHI]], i64 8
; CHECK-NEXT: [[DOTNOT:%.*]] = icmp ule ptr [[VALUE_PHI]], null
; CHECK-NEXT: br i1 [[DOTNOT]], label [[L13]], label [[L15:%.*]]
; CHECK: L13:
; CHECK-NEXT: br label [[L3]]
; CHECK: L15:
; CHECK-NEXT: ret void
;
top:
br label %L3

L3:
%value_phi = phi ptr [ null, %top ], [ %0, %L13 ]
%0 = getelementptr i8, ptr %value_phi, i64 8
%.not = icmp ule ptr %value_phi, null
br i1 %.not, label %L13, label %L15

L13:
br label %L3

L15:
ret void
}