Skip to content

[mlir] Lower math dialect later in gpu-lower-to-nvvm-pipeline #81489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grypp merged 1 commit into from
Feb 13, 2024
Merged

[mlir] Lower math dialect later in gpu-lower-to-nvvm-pipeline #81489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/lib/Dialect/GPU/Pipelines/GPUToNVVMPipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ void buildCommonPassPipeline(
pm.addPass(createConvertVectorToSCFPass());
pm.addPass(createConvertSCFToCFPass());
pm.addPass(createConvertNVVMToLLVMPass());
pm.addPass(createConvertMathToLLVMPass());
pm.addPass(createConvertFuncToLLVMPass());
pm.addPass(memref::createExpandStridedMetadataPass());

Expand Down Expand Up @@ -98,6 +97,7 @@ void buildHostPostPipeline(OpPassManager &pm,
GpuModuleToBinaryPassOptions gpuModuleToBinaryPassOptions;
gpuModuleToBinaryPassOptions.compilationTarget = options.cubinFormat;
pm.addPass(createGpuModuleToBinaryPass(gpuModuleToBinaryPassOptions));
pm.addPass(createConvertMathToLLVMPass());
pm.addPass(createCanonicalizerPass());
pm.addPass(createCSEPass());
pm.addPass(createReconcileUnrealizedCastsPass());
Expand Down
30 changes: 30 additions & 0 deletions mlir/test/Dialect/GPU/test-nvvm-pipeline.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// REQUIRES: host-supports-nvptx
// RUN: mlir-opt %s \
// RUN: | mlir-opt -gpu-lower-to-nvvm-pipeline="cubin-format=isa" \
// RUN: | FileCheck %s

// RUN: mlir-opt %s \
// RUN: | mlir-opt -gpu-lower-to-nvvm-pipeline="cubin-format=isa" \
// RUN: --mlir-print-ir-after=convert-gpu-to-nvvm 2>&1 \
// RUN: | FileCheck %s --check-prefixes=CHECK-NVVM

// This test checks whether the GPU region is compiled correctly to PTX by
// pipeline. It doesn't test IR for GPU side, but it can test Host IR and
// generated PTX.

// CHECK-LABEL: llvm.func @test_math(%arg0: f32) {
func.func @test_math(%arg0 : f32) {
%c2 = arith.constant 2 : index
%c1 = arith.constant 1 : index
// CHECK: gpu.launch_func @test_math_kernel::@test_math_kernel
// CHECK: gpu.binary @test_math_kernel [#gpu.object<#nvvm.target
gpu.launch
blocks(%0, %1, %2) in (%3 = %c1, %4 = %c1, %5 = %c1)
threads(%6, %7, %8) in (%9 = %c2, %10 = %c1, %11 = %c1) {
// CHECK-NVVM: __nv_expf
%s1 = math.exp %arg0 : f32
gpu.printf "%f" %s1 : f32
gpu.terminator
}
return
}