Skip to content

Conversation

@antiagainst
Copy link
Member

The previous paragraph actually is the current definition
of the mask semantics.

@llvmbot
Copy link
Member

llvmbot commented Nov 7, 2023

@llvm/pr-subscribers-mlir-vector

@llvm/pr-subscribers-mlir

Author: Lei Zhang (antiagainst)

Changes

The previous paragraph actually is the current definition
of the mask semantics.


Full diff: https://github.com/llvm/llvm-project/pull/71490.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Vector/IR/VectorOps.td (-4)
diff --git a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
index e6189bce88f522b..bbff7e2d18b01b4 100644
--- a/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
+++ b/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
@@ -1455,10 +1455,6 @@ def Vector_TransferWriteOp :
     any permutation. Elements whose corresponding mask element is `0` are
     masked out.
 
-    An optional SSA value `mask` of the same shape as the vector type may be
-    specified to mask out elements. Elements whose corresponding mask element
-    is `0` are masked out.
-
     An optional boolean array attribute `in_bounds` specifies for every vector
     dimension if the transfer is guaranteed to be within the source bounds. If
     specified, the `in_bounds` array length has to be equal to the vector rank.

Copy link
Contributor

@dcaballe dcaballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@antiagainst antiagainst merged commit 77cd1ad into llvm:main Nov 7, 2023
@antiagainst antiagainst deleted the fix-vector-doc branch November 7, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants