Test for future commit in NewGVN #66313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The fix for this test case is in #66314 |
kmitropoulou
force-pushed
the
set_parent
branch
from
0438dcd to
f4f7eda
Compare
nikic
approved these changes
Sep 18, 2023
| @c = global i32 0, align 4 | ||
|
|
||
| ; Function Attrs: nounwind optsize uwtable | ||
| define dso_local i32 @main(i1 %cond, i32 %0, i32 %1) { |
Contributor
There was a problem hiding this comment.
Can drop dso_local. I'd also recommend to avoid the use of unnamed values, i.e. replace i32 %0 with i32 %arg0 etc.
Contributor
Author
There was a problem hiding this comment.
I am sorry I missed this comment. I created a new pr: #66711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.