Skip to content

[clang-tidy] Avoid checking magic numbers if _BitInt #65888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vabridgers merged 1 commit into from
Sep 17, 2023
Merged

[clang-tidy] Avoid checking magic numbers if _BitInt #65888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ bool MagicNumbersCheck::isConstant(const MatchFinder::MatchResult &Result,
}

bool MagicNumbersCheck::isIgnoredValue(const IntegerLiteral *Literal) const {
if (Literal->getType()->isBitIntType()) {
return true;
}
const llvm::APInt IntValue = Literal->getValue();
const int64_t Value = IntValue.getZExtValue();
if (Value == 0)
Expand Down
6 changes: 6 additions & 0 deletions clang-tools-extra/test/clang-tidy/checkers/readability/bitint-no-crash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// RUN: %check_clang_tidy %s readability-magic-numbers %t --

// Don't crash

_BitInt(128) A = 4533629751480627964421wb;
// CHECK-MESSAGES: warning