Skip to content

[GitHub] Add main LLVM Dialect path to MLIR LLVM PR subscribers #65513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zero9178 merged 2 commits into from
Sep 7, 2023
Merged

[GitHub] Add main LLVM Dialect path to MLIR LLVM PR subscribers #65513

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c855e09
[GitHub] Add main LLVM Dialect path to MLIR LLVM PR subscribers
zero9178 Sep 6, 2023
1b0c83e
Use `LLVM*` patten instead of adding an entry with `LLVMIR`
zero9178 Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@

# mlir-llvm
/mlir/**/LLVM/ @llvm/pr-subscribers-mlir-llvm
Copy link
Collaborator

@joker-eph joker-eph Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we just remove the trailing / here?

Copy link
Member Author

@zero9178 zero9178 Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this using git check-ignore (since this should be the same syntax as for the codeowners file apparently) and that at least did not work for any checks in the LLVMIR directory.
Changing it to either LLVMIR with or without the slash works, but it seems to me like it doesn't treat trailing positions specially.

Unless GitHub CodeOwners files do it differently.

Copy link
Collaborator

@joker-eph joker-eph Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! We need a trailing *, which means most of the existing patterns are incorrect...
mlir/**/LLVM* should match both here.

/mlir/**/LLVMIR/ @llvm/pr-subscribers-mlir-llvm

# mlir-linalg
/mlir/**/*Linalg @llvm/pr-subscribers-mlir-linalg
Expand Down