Skip to content

[ADT] Fix an empty BitVector call getData assert `idx < size()' failed #65505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zero9178 merged 1 commit into from
Sep 8, 2023
Merged

[ADT] Fix an empty BitVector call getData assert `idx < size()' failed #65505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/ADT/BitVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ class BitVector {
}
bool isInvalid() const { return Size == (unsigned)-1; }

ArrayRef<BitWord> getData() const { return {&Bits[0], Bits.size()}; }
ArrayRef<BitWord> getData() const { return {Bits.data(), Bits.size()}; }

//===--------------------------------------------------------------------===//
// Portable bit mask operations.
Expand Down
8 changes: 8 additions & 0 deletions llvm/unittests/ADT/BitVectorTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,14 @@ TYPED_TEST(BitVectorTest, EmptyVector) {
testEmpty(E);
}

/// Make sure calling getData() is legal even on an empty BitVector
TYPED_TEST(BitVectorTest, EmptyVectorGetData) {
BitVector A;
testEmpty(A);
auto B = A.getData();
EXPECT_TRUE(B.empty());
}

TYPED_TEST(BitVectorTest, Iterators) {
TypeParam Filled(10, true);
EXPECT_NE(Filled.set_bits_begin(), Filled.set_bits_end());
Expand Down