[clang][deps] Always initialize module cache out params

[jansvoboda11]

We did not initialize the out parameters in #192347, causing the "sanitizer-x86_64-linux-fast" bot to complain with:

SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:1525:63 in compileModuleImpl(clang::CompilerInstance&, clang::SourceLocation, clang::SourceLocation, clang::Module*, clang::ModuleFileName)
Exiting
==clang==3084515==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x586360f7a604 in compileModuleImpl(clang::CompilerInstance&, clang::SourceLocation, clang::SourceLocation, clang::Module*, clang::ModuleFileName) /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:1525:63
    #1 <...>

This PR should fix that.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Jan Svoboda (jansvoboda11)

Changes

We did not initialize the out parameters in #192347, causing the "sanitizer-x86_64-linux-fast" bot to complain with:

SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:1525:63 in compileModuleImpl(clang::CompilerInstance&, clang::SourceLocation, clang::SourceLocation, clang::Module*, clang::ModuleFileName)
Exiting
==clang==3084515==WARNING: MemorySanitizer: use-of-uninitialized-value
    #<!-- -->0 0x586360f7a604 in compileModuleImpl(clang::CompilerInstance&amp;, clang::SourceLocation, clang::SourceLocation, clang::Module*, clang::ModuleFileName) /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:1525:63
    #<!-- -->1 &lt;...&gt;

This PR should fix that.

---

Full diff: https://github.com/llvm/llvm-project/pull/194082.diff

1 Files Affected:

• (modified) clang/lib/DependencyScanning/InProcessModuleCache.cpp (+4)

diff --git a/clang/lib/DependencyScanning/InProcessModuleCache.cpp b/clang/lib/DependencyScanning/InProcessModuleCache.cpp
index 987703b0c2b6b..0e2286c18e902 100644
--- a/clang/lib/DependencyScanning/InProcessModuleCache.cpp
+++ b/clang/lib/DependencyScanning/InProcessModuleCache.cpp
@@ -147,12 +147,16 @@ class InProcessModuleCache : public ModuleCache {
     if (Entry.State == ModuleCacheEntry::S_Written) {
       assert(Entry.Buffer && *Entry.Buffer == Buffer &&
              "Wrote the same PCM with different contents");
+      Size = Entry.Buffer->getBufferSize();
+      ModTime = Entry.ModTime;
       return {};
     }
     Entry.Buffer =
         llvm::MemoryBuffer::getMemBufferCopy(Buffer.getBuffer(), Path);
     Entry.ModTime = llvm::sys::toTimeT(std::chrono::system_clock::now());
     Entry.State = ModuleCacheEntry::S_Written;
+    Size = Entry.Buffer->getBufferSize();
+    ModTime = Entry.ModTime;
     return {};
   }