Skip to content

[lldb][test] Add SBExpressionOptions parameter to expect_expr #177920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Michael137 merged 2 commits into from
Feb 4, 2026
+9 −5
Merged

[lldb][test] Add SBExpressionOptions parameter to expect_expr #177920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf3b8d
[lldb][test] Add SBExpressionOptions parameter to expect_expr
Michael137 Jan 26, 2026
0b55b74
fixup! remove existing options local variable
Michael137 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lldb/packages/Python/lldbsuite/test/lldbtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2575,6 +2575,7 @@ def expect_expr(
result_value=None,
result_type=None,
result_children=None,
options=None,
):
"""
Evaluates the given expression and verifies the result.
Expand All @@ -2584,20 +2585,23 @@ def expect_expr(
:param result_type: The type that the expression result should have. None if the type should not be checked.
:param result_children: The expected children of the expression result
as a list of ValueChecks. None if the children shouldn't be checked.
:param options: Expression evaluation options. None if a default set of options should be used.
"""
self.assertTrue(
expr.strip() == expr,
"Expression contains trailing/leading whitespace: '" + expr + "'",
)

frame = self.frame()
options = lldb.SBExpressionOptions()

# Disable fix-its that tests don't pass by accident.
options.SetAutoApplyFixIts(False)
if not options:
options = lldb.SBExpressionOptions()

# Set the usual default options for normal expressions.
options.SetIgnoreBreakpoints(True)
# Disable fix-its that tests don't pass by accident.
options.SetAutoApplyFixIts(False)

# Set the usual default options for normal expressions.
options.SetIgnoreBreakpoints(True)

if self.frame().IsValid():
options.SetLanguage(frame.GuessLanguage())
Expand Down
Loading