[llvm][NFC] Simplify implementation of isa
#161403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-llvm-support Author: Victor Chernyakin (localspook) ChangesUsing a fold instead of template recursion. Full diff: https://github.com/llvm/llvm-project/pull/161403.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Support/Casting.h b/llvm/include/llvm/Support/Casting.h
index 66fdcb44ea2c0..2a9a149327d83 100644
--- a/llvm/include/llvm/Support/Casting.h
+++ b/llvm/include/llvm/Support/Casting.h
@@ -544,14 +544,9 @@ struct CastInfo<To, std::optional<From>> : public OptionalValueCast<To, From> {
///
/// if (isa<Type>(myVal)) { ... }
/// if (isa<Type0, Type1, Type2>(myVal)) { ... }
-template <typename To, typename From>
-[[nodiscard]] inline bool isa(const From &Val) {
- return CastInfo<To, const From>::isPossible(Val);
-}
-
-template <typename First, typename Second, typename... Rest, typename From>
+template <typename... To, typename From>
[[nodiscard]] inline bool isa(const From &Val) {
- return isa<First>(Val) || isa<Second, Rest...>(Val);
+ return (CastInfo<To, const From>::isPossible(Val) || ...);
}
/// cast<X> - Return the argument parameter cast to the specified type. This
|
kuhar
approved these changes
Sep 30, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
Using a fold instead of template recursion.
AnthonyLatsis
added a commit
to swiftlang/swift
that referenced
this pull request
Dec 11, 2025
See llvm/llvm-project#161403. These `isa` calls with a `CanType` no longer compile with LLVM next because the implementation now unfolds directly to `CastInfo` calls rather than non-variadic `isa` calls that resolve to our partial specializations here: https://github.com/swiftlang/swift/blob/e293876e4f3e376b29cdb225962e1f76cfcfbed7/include/swift/AST/Type.h#L600 We should partially specialize `CastInfo` instead of `isa` et al. For For now, just use the non-variadic `isa`.
AnthonyLatsis
added a commit
to swiftlang/swift
that referenced
this pull request
Dec 11, 2025
See llvm/llvm-project#161403. These `isa` calls with a `CanType` no longer compile with LLVM next because the implementation now unfolds directly to `CastInfo` calls rather than non-variadic `isa` calls that resolve to our partial specializations here: https://github.com/swiftlang/swift/blob/e293876e4f3e376b29cdb225962e1f76cfcfbed7/include/swift/AST/Type.h#L600 We should partially specialize `CastInfo` instead of `isa` et al. For now, just use the non-variadic `isa`.
AnthonyLatsis
added a commit
to swiftlang/swift
that referenced
this pull request
Dec 11, 2025
See llvm/llvm-project#161403. These `isa` calls with a `CanType` no longer compile with LLVM next because the implementation now unfolds directly to `CastInfo` calls rather than non-variadic `isa` calls that resolve to our partial specializations here: https://github.com/swiftlang/swift/blob/e293876e4f3e376b29cdb225962e1f76cfcfbed7/include/swift/AST/Type.h#L600 We should partially specialize `CastInfo` instead of `isa` et al. For now, just use the non-variadic `isa`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a fold instead of template recursion.