-
Notifications
You must be signed in to change notification settings - Fork 16k
[DA] Check monotonicity for subscripts #154527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 18 commits
a0d05ec
75639b9
5063efc
4dad091
8986cd4
dcb3b19
e93be2e
72b2902
b5ca793
65ccc61
d113571
137c193
f9b2a4e
e83fdb8
a098743
b16cc64
98a5de4
8c4f97b
c563a8f
55df30a
85129c6
e15715e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -547,9 +547,9 @@ define double @test_sizes(i16 %h, i16 %N, ptr nocapture %array) { | |
| ; CHECK-NEXT: Src: %2 = load i16, ptr %arrayidx, align 4 --> Dst: %2 = load i16, ptr %arrayidx, align 4 | ||
| ; CHECK-NEXT: da analyze - consistent input [0 S]! | ||
| ; CHECK-NEXT: Src: %2 = load i16, ptr %arrayidx, align 4 --> Dst: store i16 %add6, ptr %arrayidx8, align 4 | ||
| ; CHECK-NEXT: da analyze - anti [* *|<]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i16 %add6, ptr %arrayidx8, align 4 --> Dst: store i16 %add6, ptr %arrayidx8, align 4 | ||
| ; CHECK-NEXT: da analyze - output [* *]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| %cmp28 = icmp sgt i16 %N, 1 | ||
|
|
@@ -646,11 +646,11 @@ exit: | |
| define void @coeff_may_negative(ptr %a, i32 %k) { | ||
| ; CHECK-LABEL: 'coeff_may_negative' | ||
| ; CHECK-NEXT: Src: store i8 42, ptr %idx.0, align 1 --> Dst: store i8 42, ptr %idx.0, align 1 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i8 42, ptr %idx.0, align 1 --> Dst: store i8 42, ptr %idx.1, align 1 | ||
| ; CHECK-NEXT: da analyze - output [*|<]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i8 42, ptr %idx.1, align 1 --> Dst: store i8 42, ptr %idx.1, align 1 | ||
| ; CHECK-NEXT: da analyze - none! | ||
|
Comment on lines
-649
to
-653
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this is a case where the test results were correctly updated. We cannot prove |
||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %loop | ||
|
|
@@ -685,11 +685,11 @@ exit: | |
| define void @coeff_positive(ptr %a, i32 %k) { | ||
| ; CHECK-LABEL: 'coeff_positive' | ||
| ; CHECK-NEXT: Src: store i8 42, ptr %idx.0, align 1 --> Dst: store i8 42, ptr %idx.0, align 1 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i8 42, ptr %idx.0, align 1 --> Dst: store i8 42, ptr %idx.1, align 1 | ||
| ; CHECK-NEXT: da analyze - output [*|<]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i8 42, ptr %idx.1, align 1 --> Dst: store i8 42, ptr %idx.1, align 1 | ||
| ; CHECK-NEXT: da analyze - none! | ||
|
Comment on lines
-688
to
-692
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Regarding this case, I think the original results are also correct. But to reason correctly, we need to infer that |
||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %loop | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ define void @gcd0(ptr %A, ptr %B) nounwind uwtable ssp { | |
| ; CHECK-NEXT: Src: %0 = load i32, ptr %arrayidx7, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %0, ptr %B.addr.11, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %for.cond1.preheader | ||
|
|
@@ -84,7 +84,7 @@ define void @gcd1(ptr %A, ptr %B) nounwind uwtable ssp { | |
| ; CHECK-NEXT: Src: %0 = load i32, ptr %arrayidx8, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %0, ptr %B.addr.11, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %for.cond1.preheader | ||
|
|
@@ -144,7 +144,7 @@ define void @gcd2(ptr %A, ptr %B) nounwind uwtable ssp { | |
| ; CHECK-NEXT: Src: %0 = load i32, ptr %arrayidx8, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %0, ptr %B.addr.11, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %for.cond1.preheader | ||
|
|
@@ -204,7 +204,7 @@ define void @gcd3(ptr %A, ptr %B) nounwind uwtable ssp { | |
| ; CHECK-NEXT: Src: %0 = load i32, ptr %arrayidx6, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %0, ptr %B.addr.11, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %for.cond1.preheader | ||
|
|
@@ -262,7 +262,7 @@ define void @gcd4(ptr %A, ptr %B, i64 %M, i64 %N) nounwind uwtable ssp { | |
| ; CHECK-NEXT: Src: %0 = load i32, ptr %arrayidx16, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %0, ptr %B.addr.11, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %for.cond1.preheader | ||
|
|
@@ -330,7 +330,7 @@ define void @gcd5(ptr %A, ptr %B, i64 %M, i64 %N) nounwind uwtable ssp { | |
| ; CHECK-NEXT: Src: %0 = load i32, ptr %arrayidx16, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %0, ptr %B.addr.11, align 4 --> Dst: store i32 %0, ptr %B.addr.11, align 4 | ||
| ; CHECK-NEXT: da analyze - none! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; | ||
| entry: | ||
| br label %for.cond1.preheader | ||
|
|
@@ -465,13 +465,13 @@ for.end12: ; preds = %for.end12.loopexit, | |
| define void @gcd7(i32 %n, ptr %A, ptr %B) nounwind uwtable ssp { | ||
| ; CHECK-LABEL: 'gcd7' | ||
| ; CHECK-NEXT: Src: store i32 %7, ptr %arrayidx6, align 4 --> Dst: store i32 %7, ptr %arrayidx6, align 4 | ||
| ; CHECK-NEXT: da analyze - output [* *]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %7, ptr %arrayidx6, align 4 --> Dst: %11 = load i32, ptr %arrayidx12, align 4 | ||
| ; CHECK-NEXT: da analyze - flow [* *|<]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %7, ptr %arrayidx6, align 4 --> Dst: store i32 %11, ptr %B.addr.12, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: %11 = load i32, ptr %arrayidx12, align 4 --> Dst: %11 = load i32, ptr %arrayidx12, align 4 | ||
| ; CHECK-NEXT: da analyze - input [* *]! | ||
|
Comment on lines
-468
to
-474
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "I'm not entirely sure whether these changes are reasonable. Several |
||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: %11 = load i32, ptr %arrayidx12, align 4 --> Dst: store i32 %11, ptr %B.addr.12, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %11, ptr %B.addr.12, align 4 --> Dst: store i32 %11, ptr %B.addr.12, align 4 | ||
|
|
@@ -556,13 +556,13 @@ for.end15: ; preds = %for.end15.loopexit, | |
| define void @gcd8(i32 %n, ptr %A, ptr %B) nounwind uwtable ssp { | ||
| ; CHECK-LABEL: 'gcd8' | ||
| ; CHECK-NEXT: Src: store i32 %i.06, ptr %arrayidx, align 4 --> Dst: store i32 %i.06, ptr %arrayidx, align 4 | ||
| ; CHECK-NEXT: da analyze - output [* *]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %i.06, ptr %arrayidx, align 4 --> Dst: %5 = load i32, ptr %arrayidx12, align 4 | ||
| ; CHECK-NEXT: da analyze - flow [* *|<]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %i.06, ptr %arrayidx, align 4 --> Dst: store i32 %5, ptr %B.addr.12, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: %5 = load i32, ptr %arrayidx12, align 4 --> Dst: %5 = load i32, ptr %arrayidx12, align 4 | ||
| ; CHECK-NEXT: da analyze - input [* *]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: %5 = load i32, ptr %arrayidx12, align 4 --> Dst: store i32 %5, ptr %B.addr.12, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %5, ptr %B.addr.12, align 4 --> Dst: store i32 %5, ptr %B.addr.12, align 4 | ||
|
|
@@ -640,13 +640,13 @@ for.end15: ; preds = %for.end15.loopexit, | |
| define void @gcd9(i32 %n, ptr %A, ptr %B) nounwind uwtable ssp { | ||
| ; CHECK-LABEL: 'gcd9' | ||
| ; CHECK-NEXT: Src: store i32 %7, ptr %arrayidx6, align 4 --> Dst: store i32 %7, ptr %arrayidx6, align 4 | ||
| ; CHECK-NEXT: da analyze - output [* *]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %7, ptr %arrayidx6, align 4 --> Dst: %11 = load i32, ptr %arrayidx12, align 4 | ||
| ; CHECK-NEXT: da analyze - flow [* *|<]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %7, ptr %arrayidx6, align 4 --> Dst: store i32 %11, ptr %B.addr.12, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: %11 = load i32, ptr %arrayidx12, align 4 --> Dst: %11 = load i32, ptr %arrayidx12, align 4 | ||
| ; CHECK-NEXT: da analyze - input [* *]! | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: %11 = load i32, ptr %arrayidx12, align 4 --> Dst: store i32 %11, ptr %B.addr.12, align 4 | ||
| ; CHECK-NEXT: da analyze - confused! | ||
| ; CHECK-NEXT: Src: store i32 %11, ptr %B.addr.12, align 4 --> Dst: store i32 %11, ptr %B.addr.12, align 4 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
inboundsto the GEPs avoids these changes, but I'm not sure if they are intentionally omitted.