-
Notifications
You must be signed in to change notification settings - Fork 15.9k
[IR] Remove size argument from lifetime intrinsics #150248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
a56aec7 to
ef647f8
Compare
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/25074 Here is the relevant piece of the build log for the reference |
maurer
added a commit
to maurer/rust
that referenced
this pull request
Aug 8, 2025
In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
maurer
added a commit
to maurer/rust
that referenced
this pull request
Aug 8, 2025
In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
maurer
added a commit
to maurer/rust
that referenced
this pull request
Aug 8, 2025
In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
maurer
added a commit
to maurer/rust
that referenced
this pull request
Aug 8, 2025
In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 11, 2025
LLVM changed the way lifetime intrinsics work in llvm/llvm-project#150248. rust-lang/rust#145120 claims to fix these tests against ToT LLVM, but let's just suppress these until that goes in. Bug: 437926231 Change-Id: I4737655cdd2e4b3f00844a0b89f83c4ec11cf023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6838098 Commit-Queue: Arthur Eubanks <[email protected]> Auto-Submit: Arthur Eubanks <[email protected]> Reviewed-by: Devon Loehr <[email protected]> Commit-Queue: Devon Loehr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1499682}
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 13, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
jdonszelmann
added a commit
to jdonszelmann/rust
that referenced
this pull request
Aug 13, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 14, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 15, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 15, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 15, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Aug 15, 2025
Rollup merge of #145120 - maurer:llvm-time, r=nikic llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 18, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
Kobzol
pushed a commit
to Kobzol/rustc_codegen_gcc
that referenced
this pull request
Dec 21, 2025
llvm: Accept new LLVM lifetime format In llvm/llvm-project#150248 LLVM removed the size parameter from the lifetime format. Tolerate not having that size parameter.
DanBlackwell
added a commit
to DanBlackwell/llvm-project
that referenced
this pull request
Jan 5, 2026
This test is currently failing due to assuming single parameter lifetime.start and .end calls. This is from a change that is not present in this branch (llvm#150248). This patch corrects the CHECKs in the test. rdar://167480963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend:AArch64
backend:AMDGPU
backend:MIPS
backend:NVPTX
backend:PowerPC
backend:RISC-V
backend:SPIR-V
backend:SystemZ
backend:WebAssembly
backend:X86
backend:Xtensa
clang:codegen
IR generation bugs: mangling, exceptions, etc.
clang:openmp
OpenMP related changes to Clang
clang
Clang issues not falling into any other category
compiler-rt:sanitizer
coroutines
C++20 coroutines
flang:fir-hlfir
flang
Flang issues not falling into any other category
llvm:analysis
Includes value tracking, cost tables and constant folding
llvm:codegen
llvm:globalisel
llvm:instcombine
Covers the InstCombine, InstSimplify and AggressiveInstCombine passes
llvm:ir
llvm:SelectionDAG
SelectionDAGISel as well
llvm:transforms
mlir:llvm
mlir
PGO
Profile Guided Optimizations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #149310 has restricted lifetime intrinsics to only work on allocas, we can also drop the explicit size argument. Instead, the size is implied by the alloca.
This removes the ability to only mark a prefix of an alloca alive/dead. We never used that capability, so we should remove the need to handle that possibility everywhere (though many key places, including stack coloring, did not actually respect this).