Single byte coverage with branch coverage #113115
Draft
+643
−728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getBranchCounterPair()` allocates an additional Counter to SkipPath in `SingleByteCoverage`. `IsCounterEqual()` calculates the comparison with rewinding counter replacements. `NumRegionCounters` is updated to take additional counters in account. `incrementProfileCounter()` has a few additiona arguments. - `UseSkipPath=true`, to specify setting counters for SkipPath. It assumes `UseSkipPath=false` is used together. - `UseBoth` may be specified for marking another path. It introduces the same effect as issueing `markStmtAsUsed(!SkipPath, S)`. `llvm-cov` discovers counters in `FalseCount` to allocate `MaxCounterID` for empty profile data.
…cov/single/replace' into users/chapuni/cov/single/nextcount-base
…puni/cov/single/nextcount
Currently `first` is not None by default.
…/single/nextcount' into users/chapuni/cov/single/base
…ngle/condop' and 'users/chapuni/cov/single/if' into users/chapuni/cov/single/binop-base
…ingle/binop' and 'users/chapuni/cov/single/switch' into HEAD
…/cov/single/binop
…/single/getpair' into users/chapuni/cov/single/nextcount-base
…ingle/switch Conflicts: clang/lib/CodeGen/CoverageMappingGen.cpp
Conflicts: clang/lib/CodeGen/CodeGenFunction.h
…cov/single/loop Conflicts: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CoverageMappingGen.cpp
…cov/single/condop
…cov/single/switch
…ngle/condop' and 'users/chapuni/cov/single/if' into users/chapuni/cov/single/binop-base
…/cov/single/binop
…v/single/switch' into users/chapuni/cov/single/trunk
🪟 Windows x64 Test Results
✅ The build succeeded and all tests passed. |
- s/`TheMap`/`TheCounterPair`/ - Change the type of `Counter` to `ValueOpt`.
…dc/nest/mcdcstate
…ngle/trunk Conflicts: clang/docs/ReleaseNotes.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discourse.llvm.org/t/rfc-integrating-singlebytecoverage-with-branch-coverage/82492
This is squashed view of my requests.
Preparations
--binary-counters#120841getBranchCounterPair(). NFC. #112702CounterPairfor RegionCounterMap. NFC. #112724Practical changes
BinLAndandBinLOr#113113