Skip to content

[AMDGPU] Error on non-global pointer with s_prefetch_data #107624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rampitec merged 5 commits into from
Sep 13, 2024
Merged

[AMDGPU] Error on non-global pointer with s_prefetch_data #107624

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a58d1a
[AMDGPU] Error on non-global pointer with s_prefetch_data
rampitec Sep 6, 2024
3f3af45
Merge branch 'main' into s_prefgetch_data_err
rampitec Sep 9, 2024
c50067c
Moved to verifier
rampitec Sep 9, 2024
13f2cef
Address review comments
rampitec Sep 11, 2024
a407189
clang-format
rampitec Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llvm/lib/IR/Verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6281,6 +6281,12 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) {
"Value for inactive lanes must be a VGPR function argument", &Call);
break;
}
case Intrinsic::amdgcn_s_prefetch_data: {
unsigned AS = Call.getArgOperand(0)->getType()->getPointerAddressSpace();
Check(AS == 0 || AS == 1 || AS == 4,
"s_prefetch_data only supports global or constant memory");
break;
}
case Intrinsic::nvvm_setmaxnreg_inc_sync_aligned_u32:
case Intrinsic::nvvm_setmaxnreg_dec_sync_aligned_u32: {
Value *V = Call.getArgOperand(0);
Expand Down
9 changes: 0 additions & 9 deletions llvm/test/CodeGen/AMDGPU/llvm.amdgcn.s.prefetch.data.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,6 @@ entry:
ret void
}

define amdgpu_ps void @prefetch_data_sgpr_base_imm_len_local(ptr addrspace(3) inreg %ptr) {
; GCN-LABEL: prefetch_data_sgpr_base_imm_len_local:
; GCN: ; %bb.0: ; %entry
; GCN-NEXT: s_endpgm
entry:
tail call void @llvm.amdgcn.s.prefetch.data.p3(ptr addrspace(3) %ptr, i32 31)
ret void
}

define amdgpu_ps void @prefetch_data_vgpr_base_imm_len(ptr addrspace(4) %ptr) {
; GCN-LABEL: prefetch_data_vgpr_base_imm_len:
; GCN: ; %bb.0: ; %entry
Expand Down
8 changes: 8 additions & 0 deletions llvm/test/Verifier/AMDGPU/intrinsic-prefetch.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s

define amdgpu_ps void @prefetch_data_sgpr_base_imm_len_local(ptr addrspace(3) inreg %ptr) {
entry:
; CHECK:s_prefetch_data only supports global or constant memory
tail call void @llvm.amdgcn.s.prefetch.data.p3(ptr addrspace(3) %ptr, i32 31)
ret void
}