Skip to content

[AMDGPU][AsmParser][NFC] Remove a misleading comment. #102604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kosarev merged 1 commit into from
Aug 9, 2024
Merged

[AMDGPU][AsmParser][NFC] Remove a misleading comment. #102604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2937,10 +2937,6 @@ unsigned AMDGPUAsmParser::ParseRegularReg(RegisterKind &RegKind,
StringRef RegSuffix = RegName.substr(RI->Name.size());
unsigned SubReg = NoSubRegister;
if (!RegSuffix.empty()) {
// We don't know the opcode till we are done parsing, so we don't know if
// registers should be 16 or 32 bit. It is therefore mandatory to put .l or
// .h to correctly specify 16 bit registers. We also can't determine class
// VGPR_16_Lo128 or VGPR_16, so always parse them as VGPR_16.
if (RegSuffix.consume_back(".l"))
SubReg = AMDGPU::lo16;
else if (RegSuffix.consume_back(".h"))
Expand Down