Fix tests for https://github.com/llvm/llvm-project/pull/89884#100061
Merged
Conversation
Merged
Contributor
|
LGTM. Nit: current pattern is to not have space in |
alx32
approved these changes
Jul 23, 2024
Contributor
Author
Looking at other tests, they also seem have space -- https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-exegesis/X86/latency/loop-register.s#L1 |
Contributor
Indeed, now I see it varies depending on tests - so either is fine. |
Contributor
|
Thank you @kyulee-com |
gulfemsavrun
added a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit d3fb41d and forward fix patches because of the issue explained in: #89884 (comment). Revert "Fix tests for #89884 (#100061)" This reverts commit 67937a3. Revert "Fix build break for #89884 (#100050)" This reverts commit c33878c. Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)" This reverts commit 1f8b2b1.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251302
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
This reverts commit d3fb41d and forward fix patches because of the issue explained in: #89884 (comment). Revert "Fix tests for #89884 (#100061)" This reverts commit 67937a3. Revert "Fix build break for #89884 (#100050)" This reverts commit c33878c. Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)" This reverts commit 1f8b2b1.
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 14, 2024
This reverts commit d3fb41d and forward fix patches because of the issue explained in: llvm#89884 (comment). Revert "Fix tests for llvm#89884 (llvm#100061)" This reverts commit 67937a3. Revert "Fix build break for llvm#89884 (llvm#100050)" This reverts commit c33878c. Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)" This reverts commit 1f8b2b1. (cherry picked from commit 73d7897)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 19, 2024
This reverts commit d3fb41d and forward fix patches because of the issue explained in: llvm#89884 (comment). Revert "Fix tests for llvm#89884 (llvm#100061)" This reverts commit 67937a3. Revert "Fix build break for llvm#89884 (llvm#100050)" This reverts commit c33878c. Revert "[CGData] Fix -Wpessimizing-move in CodeGenDataReader.cpp (NFC)" This reverts commit 1f8b2b1. (cherry picked from commit 73d7897)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.