Skip to content

[CIR] Backport support zero init attr for all FP types #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2025
Merged

[CIR] Backport support zero init attr for all FP types #1536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58ddee1
[CIR] Backport support zero init attr for all FP types
AmrDeveloper Mar 31, 2025
4642fbb
Add test cases
AmrDeveloper Apr 1, 2025
5ab4b5a
Add f128 support in convertType
AmrDeveloper Apr 1, 2025
b9820a5
Fix global var simple tests
AmrDeveloper Apr 1, 2025
8231246
Remove testing run
AmrDeveloper Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,8 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
mlir::TypedAttr getZeroInitAttr(mlir::Type ty) {
if (mlir::isa<cir::IntType>(ty))
return cir::IntAttr::get(ty, 0);
if (auto fltType = mlir::dyn_cast<cir::SingleType>(ty))
return cir::FPAttr::getZero(fltType);
if (auto fltType = mlir::dyn_cast<cir::DoubleType>(ty))
return cir::FPAttr::getZero(fltType);
if (auto fltType = mlir::dyn_cast<cir::FP16Type>(ty))
return cir::FPAttr::getZero(fltType);
if (auto fltType = mlir::dyn_cast<cir::BF16Type>(ty))
return cir::FPAttr::getZero(fltType);
if (cir::isAnyFloatingPointType(ty))
return cir::FPAttr::getZero(ty);
if (auto complexType = mlir::dyn_cast<cir::ComplexType>(ty))
return getZeroAttr(complexType);
if (auto arrTy = mlir::dyn_cast<cir::ArrayType>(ty))
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/CIR/Dialect/IR/CIRTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ LongDoubleType::verify(function_ref<InFlightDiagnostic()> emitError,

bool cir::isAnyFloatingPointType(mlir::Type t) {
return isa<cir::SingleType, cir::DoubleType, cir::LongDoubleType,
cir::FP80Type>(t);
cir::FP80Type, cir::BF16Type, cir::FP16Type, cir::FP128Type>(t);
}

bool cir::isScalarType(mlir::Type ty) {
Expand Down
Loading