-
Notifications
You must be signed in to change notification settings - Fork 179
[CIR][CodeGen] Add support for x86 memory fence #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][CodeGen] Add support for x86 memory fence #1519
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
@bcardosolopes @FantasqueX can you please review this PR as I am getting the test fails due to the filecheck issue , Can you help me understand how exactly i have to modify the rdtsc test case . The CIR that I am able to generate is : Thank you. |
if that's causing confusion, perhaps remove it from this PR and land first the other intrinsics? |
|
#1523 for BI__rdtsc |
|
Please rename the PR to be consistent with the new content |
bcardosolopes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after changing the title!
|
done 👍🏻 |
No description provided.