[CIR][CIRGen] Simplify __builtin_elementwise_abs #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancern
requested changes
Feb 24, 2025
Member
Lancern
left a comment
Lancern
left a comment
There was a problem hiding this comment.
AFAIK, emitUnaryFPBuiltin does not check for CGF.getBuilder().getIsFPConstrained(), while emitUnaryMaybeConstrainedFPBuiltin does. Although constraint FP arithmetic is not implemented yet, we intentionally leave it there thus we could more easily implement it in the future.
Collaborator
Author
|
OG uses |
xlauko
pushed a commit
to xlauko/clangir
that referenced
this pull request
Feb 28, 2025
If type of operand is not integer, it can be handled like what I do in `__builtin_elementwise_exp`.
xlauko
pushed a commit
to xlauko/clangir
that referenced
this pull request
Feb 28, 2025
If type of operand is not integer, it can be handled like what I do in `__builtin_elementwise_exp`.
Collaborator
Author
|
@Lancern Hi, I agree with you that |
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
If type of operand is not integer, it can be handled like what I do in `__builtin_elementwise_exp`.
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
If type of operand is not integer, it can be handled like what I do in `__builtin_elementwise_exp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If type of operand is not integer, it can be handled like what I do in
__builtin_elementwise_exp.