`CIRGenTypes::convertTypeForMem` and `bool`

[dkolsen-pgi]

The documentation for CIRGenTypes::convertTypeForMem states that it treats bool specially:

  /// Convert type T into an mlir::Type. This differs from convertType in that
  /// it is used to convert to the memory representation for a type. For
  /// example, the scalar representation for bool is i1, but the memory
  /// representation is usually i8 or i32, depending on the target.

But the implementation of CIRGenTypes::convertTypeForMem in CIRGenTypes.cpp doesn't check for bool or do anything special for bool.

Either the documentation or the implementation is wrong. I don't know which. One of them needs to be fixed.

[bcardosolopes]

Either the documentation or the implementation is wrong. I don't know which. One of them needs to be fixed.

We differ from OG here. Documentation should state the we use cir.bool in CIR and that the lowering process takes care of using the right memory representation - this was recently fixed by @orbiri

[seven-mile]

Fixed in #1279.

[seven-mile]

Sorry, I missed the actual situation. #1279 was created before this issue. The misleading statement about bool type still remains. Submitted #1526 to fix it.