Skip to content

improved log output for NLP scaling#709

Merged
cnpetra merged 2 commits intodevelopfrom
nlpscaling-log
Feb 17, 2025
Merged

improved log output for NLP scaling#709
cnpetra merged 2 commits intodevelopfrom
nlpscaling-log

Conversation

@cnpetra
Copy link
Collaborator

@cnpetra cnpetra commented Feb 12, 2025

Logs (for verbosity>=4) info on the internal NLP scaling such as which scaling method and some scaling scalars.

@cnpetra cnpetra marked this pull request as draft February 12, 2025 22:10
@cnpetra cnpetra requested a review from nychiang February 12, 2025 22:56
@cnpetra cnpetra marked this pull request as ready for review February 12, 2025 22:56
Copy link
Collaborator

@nychiang nychiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about what brings you here to modify this log output. :-)

@cnpetra
Copy link
Collaborator Author

cnpetra commented Feb 13, 2025

Just curious about what brings you here to modify this log output. :-)

ill-scaled problem :)

@cnpetra cnpetra merged commit d235c7e into develop Feb 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants