Merged
Conversation
nychiang
force-pushed
the
support-cpp17-dev
branch
from
9ce8a68 to
21262f0
Compare
nychiang
force-pushed
the
support-cpp17-dev
branch
from
21262f0 to
f9ef443
Compare
cnpetra
approved these changes
Feb 3, 2025
Collaborator
|
@nychiang can you please confirm |
pelesh
reviewed
Feb 6, 2025
CMakeLists.txt
Outdated
Comment on lines
+5
to
+6
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17 -lstdc++fs ") | ||
|
|
Collaborator
There was a problem hiding this comment.
I am not sure if this is portable. It will probably not work with MSVC, for example.
Kitware suggests adding language standards to targets such as
target_compile_features(HIOP PRIVATE cxx_std_17)My understanding is that the built-in target cxx_std_17 is supposed to add correct flags for the compiler of your selection.
Collaborator
Author
Collaborator
There was a problem hiding this comment.
I doubt it is going to be an issue, because ExaGO only links to HiOp.
Collaborator
Author
There was a problem hiding this comment.
after checking others' code, e.g., RAJA, MFEM, etc..., I don't think I need to specify -std=c++17 or target_compile_features. Just pushed another commit for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set C++17 as the standard in CMake files