Merged
Conversation
Collaborator
|
lgtm. we are looking into fixing/updating the CI. |
cnpetra
approved these changes
Jan 22, 2025
Collaborator
|
@cnpetra I rebase it to a new branch from the latest develop. let's merge this one to that branch first. Then I can check if CI works there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
hipblasinclude fromhipblas.htohipblas/hipblas.hfor ROCm>=5.2. The paths have changed, and backward compatibility was removed in more recent ROCm versions. I found the issue when attempting to build with ROCm 6.3.1 on Frontier, and these changes seem to fix it at the build stage.Got the idea of the fix from Magma.
cc @pelesh @cnpetra