Skip to content

Conversation

@rhdedgar
Copy link
Contributor

@rhdedgar rhdedgar commented Dec 3, 2025

What does this PR do?

Enables lllama-stack multi-architecture builds for ARM. The result is an image index, that will point to the image associated with the calling user's architecture.

On Kubernetes for example, with these changes, images are still referred to in the same manner, but will resolve to the architecture that is relevant to the node where it is to be run.

                                              --> quay.io/<user>/distribution-starter/<version>-linux-arm64
quay.io/<user>/distribution-starter/<version>-|
                                              --> quay.io/<user>/distribution-starter/<version>-linux-amd64

In practice, referring to the usual docker.io/llamastack/distribution-starter:latest should resolve to the image with the requesting user's relevant architecture, without any additional configuration on the user's side.

Closes #406

Test Plan

Tested container builds on an amd64 architecture host, and deployed the starter distribution image via llama-stack-k8s-operator to an arm64 architecture OpenShift cluster. The deployment ran and the operator's e2e test suite completed as expected.

Arm64-specific build tests run and pass on GitHub.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 3, 2025
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! ❤️

Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. @leseb @cdoern you want to have one look?

Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks! I believe the next step is to publish a build and take inspiration from .github/workflows/build-distributions.yml in the ops repo.

Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build never ran. https://github.com/llamastack/llama-stack/actions/runs/20277364473 there is an issue with the matrix.

@rhdedgar
Copy link
Contributor Author

Good catch, I see the issue now. I've updated this PR with a new commit. The tests have passed again, and the build now completes: https://github.com/llamastack/llama-stack/actions/runs/20313646963.

@rhdedgar
Copy link
Contributor Author

Might need a maintainer to remove that requested change label unless we should wait until everyone is back after New Year's before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload arm64 docker images where relevant

3 participants