Skip to content

feat: Pass parallel_tool_calls correctly #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anastasds wants to merge 22 commits into from
Closed

feat: Pass parallel_tool_calls correctly #4196

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
958d0dc
Pass parallel_tool_calls directly and document intended usage in inte…
anastasds Nov 19, 2025
179d5f7
Merge branch 'main' into parallel-tool-calls-impl
anastasds Nov 19, 2025
0c2b82b
Merge branch 'main' into parallel-tool-calls-impl
franciscojavierarceo Nov 21, 2025
9cbb624
Merge branch 'main' into parallel-tool-calls-impl
anastasds Dec 16, 2025
1f6e095
Delete parallel tool calls section from documentation because it has …
anastasds Nov 21, 2025
a971d8f
Document behavior of parallel_tool_calls parameter
anastasds Nov 21, 2025
bbd59b7
Run pre-commit hooks
anastasds Dec 16, 2025
a6552c0
Vendor images for parallel_tool_calls docs
anastasds Dec 16, 2025
cf75274
--signoff
anastasds Dec 16, 2025
d531c57
Default parallel_tool_calls to none
anastasds Dec 16, 2025
5c48e0a
Run latest pre-commit hooks
anastasds Dec 16, 2025
7fda120
Merge branch 'main' into parallel-tool-calls-impl
anastasds Dec 16, 2025
d3acf47
Run latest pre-commit hooks
anastasds Dec 16, 2025
d14d930
Merge branch 'main' into parallel-tool-calls-impl
anastasds Dec 16, 2025
e2030f7
Default parallel_tool_calls to None everywhere
anastasds Dec 16, 2025
983fa48
Rerun pre commit hooks
anastasds Dec 16, 2025
5214ccf
Merge branch 'main' into parallel-tool-calls-impl
anastasds Dec 16, 2025
271af12
Merge branch 'pdocs' into parallel-tool-calls-impl
anastasds Dec 16, 2025
2610b4f
Return parallel_tool_calls default to true
anastasds Dec 17, 2025
8a924a3
Add missing replays for integration tests
anastasds Dec 17, 2025
d7f8d6b
Merge branch 'main' into parallel-tool-calls-impl
anastasds Dec 17, 2025
5514378
Merge branch 'main' into parallel-tool-calls-impl
anastasds Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions client-sdks/stainless/openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6921,7 +6921,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down Expand Up @@ -7531,7 +7530,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down
2 changes: 0 additions & 2 deletions docs/static/deprecated-llama-stack-spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3747,7 +3747,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down Expand Up @@ -4357,7 +4356,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down
2 changes: 0 additions & 2 deletions docs/static/experimental-llama-stack-spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3466,7 +3466,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down Expand Up @@ -3904,7 +3903,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down
2 changes: 0 additions & 2 deletions docs/static/llama-stack-spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5563,7 +5563,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down Expand Up @@ -6173,7 +6172,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down
2 changes: 0 additions & 2 deletions docs/static/stainless-llama-stack-spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6921,7 +6921,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down Expand Up @@ -7531,7 +7530,6 @@ components:
anyOf:
- type: boolean
- type: 'null'
default: true
previous_response_id:
anyOf:
- type: string
Expand Down
1 change: 1 addition & 0 deletions src/llama_stack/providers/inline/agents/meta_reference/responses/streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ async def create_response(self) -> AsyncIterator[OpenAIResponseObjectStream]:
model=self.ctx.model,
messages=messages,
# Pydantic models are dict-compatible but mypy treats them as distinct types
parallel_tool_calls=self.parallel_tool_calls,
tools=effective_tools, # type: ignore[arg-type]
tool_choice=chat_tool_choice,
stream=True,
Expand Down
2 changes: 1 addition & 1 deletion src/llama_stack_api/openai_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ class OpenAIResponseObject(BaseModel):
model: str
object: Literal["response"] = "response"
output: Sequence[OpenAIResponseOutput]
parallel_tool_calls: bool | None = True
parallel_tool_calls: bool | None = None
Copy link
Collaborator

@mattf mattf Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the api change?

Copy link
Contributor Author

@anastasds anastasds Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is optional and so when being passed downstream, should not be set unless set by the user in their initial request. If a downstream provider defaults to False, that should not be overriden by default.

OpenAI currently defaults to true internally, but that may change, the parameter may be removed, etc., so best to not explicitly set it. (I originally defined this to be True by default and should not have.)

previous_response_id: str | None = None
prompt: OpenAIResponsePrompt | None = None
status: str
Expand Down
Loading