Skip to content

fix: do not log 'signal client closed: "stream closed"' on disconnect #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzhao merged 5 commits into from
Oct 6, 2025
Merged

fix: do not log 'signal client closed: "stream closed"' on disconnect #727

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9b3b6d
fix: do not log 'signal client closed: "stream closed"' on disconnect
davidzhao Oct 5, 2025
701962c
fix lock
davidzhao Oct 6, 2025
7532627
fmt
davidzhao Oct 6, 2025
8e2ba66
cache packages
davidzhao Oct 6, 2025
8710db0
cannot cache apt packages
davidzhao Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions livekit/src/rtc_engine/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,13 @@ impl EngineInner {
match action {
proto::leave_request::Action::Resume
| proto::leave_request::Action::Reconnect => {
let running_handle = self.running_handle.read();
Copy link
Contributor

@ladvoc ladvoc Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears reading from the RwLock on this line leads to a deadlock—I will have to dig deeper to determine why this is the case.

Copy link
Member Author

@davidzhao davidzhao Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the issue, the read lock wasn't released in time. fixed in 701962c


// server could have sent a leave & disconnected signal client
// we don't want to start another resume cycle
if !running_handle.can_reconnect {
return Ok(());
}
log::warn!(
"received session close: {:?} {:?} {:?}",
source,
Expand Down
Loading