Library evolution support (xcframework) #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #731
Resolves #790
Fixes the library evolution build failure by replacing protocols with
Selfrequirements (which cannot form a stable ABI) with protocol composition typealiases that provide a concrete existential type the compiler can support.Protocols with
Selfor associated type requirements cannot form a stable ABI because the compiler cannot create a generic, fixed-size storage container (an "existential") for them, as the concrete size and layout of the conforming type are unknown at the API boundary, making forward-compatible memory management and function dispatch impossible.This is a breaking change⚠️ for anyone e.g. extending the current hierarchy:
This should NOT be a breaking change for just consuming concrete types returned e.g. from factory methods in the SDK.