Fix serial runner cancellation #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice, will take a deeper look early next week 💯 |
pblazej
reviewed
Oct 3, 2025
| // Wait for the previous task to complete, but cancel it if needed | ||
| if let previousTask, !Task.isCancelled { | ||
| // Always wait for the previous task to maintain serial ordering | ||
| if let previousTask { |
Contributor
There was a problem hiding this comment.
I'm just wondering what would happen if we move this wait before Task (essentially "blocking" run)?
Contributor
There was a problem hiding this comment.
NVM, it just breaks the assumptions made in the 3rd test case 👍
pblazej
force-pushed
the
blaze/tests-ci
branch
from
70b457f to
4abedc8
Compare
pblazej
force-pushed
the
hiroshi/fix-serialrunner
branch
from
5bf69be to
fd4b1f2
Compare
|
|
pblazej
approved these changes
Oct 6, 2025
Contributor
pblazej
left a comment
pblazej
left a comment
There was a problem hiding this comment.
I rebased it onto main as my test branch needs more work 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The testSerialRunnerCancel() test was failing with the counter ending up negative (-1, -8, etc.) instead of the expected 0, indicating a race condition.
Root Cause
The condition !Task.isCancelled was causing cancelled tasks to skip waiting for the previous task to complete. This broke the serial execution guarantee, allowing multiple blocks to run concurrently and causing unsynchronized access to the shared counter.
Fix
Removed the !Task.isCancelled condition to ensure all tasks wait for the previous task, even when cancelled. This maintains the serial ordering guarantee that the actor is designed to provide.